From 8a7bb1dc02784f8809b06bd36adb6c909e0612e8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fredrik=20L=C3=B6nnblad?= Date: Sat, 14 Mar 2020 08:43:55 -0300 Subject: [PATCH 1/5] Update issue templates --- .github/ISSUE_TEMPLATE/bug_report.md | 30 +++++++++++++++++++++++ .github/ISSUE_TEMPLATE/feature_request.md | 20 +++++++++++++++ 2 files changed, 50 insertions(+) create mode 100644 .github/ISSUE_TEMPLATE/bug_report.md create mode 100644 .github/ISSUE_TEMPLATE/feature_request.md diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md new file mode 100644 index 0000000..92e6a4a --- /dev/null +++ b/.github/ISSUE_TEMPLATE/bug_report.md @@ -0,0 +1,30 @@ +--- +name: Bug report +about: Create a report to help us improve +title: '' +labels: bug +assignees: '' + +--- + +Please answer these questions before submitting a bug report. + +### What version of godog are you using? +``` +> godog -version +``` + +### What version of Go are you using? +``` +> go version +``` + +### What did you do? +If possible, provide a recipe for reproducing the error. + +### What did you expect to see? + +### What did you see instead? + +### Additional context +Add any other context about the problem here. diff --git a/.github/ISSUE_TEMPLATE/feature_request.md b/.github/ISSUE_TEMPLATE/feature_request.md new file mode 100644 index 0000000..bbcbbe7 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/feature_request.md @@ -0,0 +1,20 @@ +--- +name: Feature request +about: Suggest an idea for this project +title: '' +labels: '' +assignees: '' + +--- + +**Is your feature request related to a problem? Please describe.** +A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] + +**Describe the solution you'd like** +A clear and concise description of what you want to happen. + +**Describe alternatives you've considered** +A clear and concise description of any alternative solutions or features you've considered. + +**Additional context** +Add any other context or screenshots about the feature request here. From 0c0ce69ce5a52b65a72c2dd167e7181c96ceee60 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fredrik=20L=C3=B6nnblad?= Date: Sat, 14 Mar 2020 08:44:56 -0300 Subject: [PATCH 2/5] Update issue templates --- .github/ISSUE_TEMPLATE/feature_request.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/feature_request.md b/.github/ISSUE_TEMPLATE/feature_request.md index bbcbbe7..4fe86d5 100644 --- a/.github/ISSUE_TEMPLATE/feature_request.md +++ b/.github/ISSUE_TEMPLATE/feature_request.md @@ -2,7 +2,7 @@ name: Feature request about: Suggest an idea for this project title: '' -labels: '' +labels: feature assignees: '' --- From c64517055d94bf43d75dbfa5d1be1ae3f7a2428b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fredrik=20L=C3=B6nnblad?= Date: Sat, 14 Mar 2020 08:50:44 -0300 Subject: [PATCH 3/5] Create CONTRIBUTING.md --- CONTRIBUTING.md | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) create mode 100644 CONTRIBUTING.md diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md new file mode 100644 index 0000000..6c4e8fb --- /dev/null +++ b/CONTRIBUTING.md @@ -0,0 +1,17 @@ +## About to contribute? + +We appreciate that. But before you do, please learn our basic rules: + +* Do you have a feature request? Then don't expect it to be implemented unless + you or someone else sends a [pull request](https://help.github.com/articles/using-pull-requests). +* We love [pull requests](https://help.github.com/articles/using-pull-requests), + but if you don't have a test to go with it we probably won't merge it. +* Before making significant contribution consider discussing the outline of + your solution first. This may avoid a duplication of efforts. + +Please do *not* add @author tags - this project embraces collective code +ownership. If you want to know who wrote some code, look in git. When you are +done, send a [pull request](http://help.github.com/send-pull-requests/). +If we get a pull request where an entire file is changed because of +insignificant whitespace changes we cannot see what you have changed, and your +contribution might get rejected. From 3a53f6f6bffaf6ed8c3f274f96e3066b789720fb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fredrik=20L=C3=B6nnblad?= Date: Sun, 15 Mar 2020 10:03:09 -0300 Subject: [PATCH 4/5] Update README.md --- README.md | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/README.md b/README.md index 5226fd6..2be6b49 100644 --- a/README.md +++ b/README.md @@ -176,7 +176,6 @@ import ( "fmt" "github.com/cucumber/godog" - messages "github.com/cucumber/messages-go/v9" ) func thereAreGodogs(available int) error { @@ -204,7 +203,7 @@ func FeatureContext(s *godog.Suite) { s.Step(`^I eat (\d+)$`, iEat) s.Step(`^there should be (\d+) remaining$`, thereShouldBeRemaining) - s.BeforeScenario(func(*messages.Pickle) { + s.BeforeScenario(func(interface{}) { Godogs = 0 // clean the state before every scenario }) } From 05db4cc9a96f96af2fc35e48f9f0a4a1c89f7e84 Mon Sep 17 00:00:00 2001 From: Denis Trofimov Date: Mon, 16 Mar 2020 12:24:05 +0300 Subject: [PATCH 5/5] Fix #262 Bug then running the example of an API, a feature version need to bump to latest reported 0.8.1 #262 --- _examples/api/features/version.feature | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/_examples/api/features/version.feature b/_examples/api/features/version.feature index 950c164..92c0a05 100644 --- a/_examples/api/features/version.feature +++ b/_examples/api/features/version.feature @@ -20,6 +20,6 @@ Feature: get version And the response should match json: """ { - "version": "v0.7.14" + "version": "v0.8.1" } """