Граф коммитов

21 коммит

Автор SHA1 Сообщение Дата
Softonik
0c030e0a6c Модуль переименован для публикации 2025-06-03 04:16:23 +03:00
Tighearnán Carroll
4a4fd8ab3a
fix(errors): Fix expected Step argument count for steps with context.Context (#679)
* fix(errors): print correct number of expected steps when step has  defined

* add unit test

* remove duplicate part from unit test

* update changelog
2025-03-19 23:04:06 +00:00
John Lonergan
223efc3b14
Fix some type checks on the signatures of nested step handlers (#647)
* at some point someone changed the return type for nested steps from []string to godog.Steps but they forgot to adjust the type checks. The existing type checks were lax and unable to distinguish  []string from godog.Steps but in a couple of places in the code the value is coerced to godog.Steps and so if someone returned []string then the code would blow up. Additionally there were some tests aroudn these types but they also had not been updated but the test was passing for the wrong reason - the particular test expected an error but the cause of the error wasn't the one the code expected.

* CHANGELOG.md

* use chatgpt to regen the top of the code based on the new tests

* use chatgpt to regen the top of the code based on the new tests

* corrected the error messages of the param checks to indicate that the problem is the function signature and not the args being passed to the function, also added numerous extra assertions on the precise error messages returned. Now that the precise error is being verified in the test I have improved certain error messages to that more accurate detail is included in the errors

* added further constraints to the step arg mapping tests

* removed redundant test

* include a step error result in the reported error even when the ctx is nil
2024-10-15 13:25:13 +01:00
John Lonergan
bcf6bce793
ambiguous step def detection akin to cucumber jvm (#636)
* added basic detection for ambiguous steps, but causes an error and not yet recorded in the reports as 'Ambiguous', and no test cases figured out yet

* added initial support for detection of ambiguous steps - further work take a look at how cuke jvm report ambiguous steps and sets the step status to 'ambiguous' rather than my current solution which just blows the test up as a regular step error

* added suite_context_test and also introduced missing 'ambiguous' status to make cucumber jvm'

* update CHANGELOG for ambiguous step defs

* missed file from commit

* added internal/formatters/fmt_multi_test.go

* add tests for other peoples code

* added "ambigous" to the help text

* tests

* added some more tests for attachments

* Update internal/flags/flags.go

Co-authored-by: Viacheslav Poturaev <nanopeni@gmail.com>

---------

Co-authored-by: Viacheslav Poturaev <nanopeni@gmail.com>
2024-07-01 10:28:39 +01:00
John Lonergan
9558224cce
Additional code review observations on Attach() functionality from https://github.com/cucumber/godog/pull/623 (#628)
* support multiple calls to the Attach() function from a single step

* run_progress_test.go changed so it's not sensitive to the name of the clone target directory

* applied code review comments also added _example/attachments

* applied code review comments also added _example/attachments

* applied code review comments also added _example/attachments
2024-05-30 02:29:14 +00:00
John Lonergan
201e526078
added support for Attachments (aka Embedddings) (#623)
* added support for attachments in the cucumber json and events output formats - done by sneaking the attachment into the context.Context object.
2024-05-29 00:02:08 +01:00
Iaroslav Ciupin
da57dd0766
Fix step duration calculation (#616) 2024-04-08 14:08:21 +02:00
Viacheslav Poturaev
ea50e4bdfc
Use staticcheck GitHub Action (#563) 2023-06-06 16:52:06 +02:00
Viacheslav Poturaev
35820ff9fe Reduce deps, fix CI for go1.16, format imports 2023-05-26 16:38:51 +02:00
Alexandru Chitu
2264a0037b
chore(*): BREAKING CHANGE, use new repos for cucumber and messages (#515)
* chore(*): use new repos for cucumber and messages

* chore(*): go mod tidy _examples

Co-authored-by: otrava7 <alexandru.chit@gmail.com>
2023-01-05 12:41:56 +01:00
Brian Hnat
5d705e5b8e
Pretty Print when using rules (#440) (#480)
* Pretty Print when using rules (#440)

* Pretty Print when using rules (#440)

* fix a few formatting mistakes (#440)

* added test with rule and scenario outline (#440)
2022-06-17 07:32:07 -07:00
Viacheslav Poturaev
b1728ff551
Add new contextualized API for hooks and steps (#409)
* Add new contextualized API for hooks and steps

* Make default context configurable

* Run AfterStep hooks even after failed steps, fixes #370

* Update CHANGELOG and README

* Add step result status to After hook, fixes #378

* Elaborate hooks documentation

* Add test to pass state between contextualized steps

* Update README with example of passing state between steps
2021-08-03 17:48:05 +02:00
Karsten Franke
7d343d4e35
Fix step definition output for Data Tables (#411)
* Fix step definition output for Data Tables

This fixes incorrect step definition output for Data Tables. The
PickleStepArgument_PickleTable type does not exist in the current
messages-go version.

* updated CHANGELOG.md
2021-07-29 10:27:00 +02:00
tfreville
63fd657a22 test: Add test for stepdef model 2021-07-13 10:35:45 +02:00
tfreville
fca39e4e89 test(convey): Add goconvey for test to ease test writting.
Add tests for panic in test_context initialization.

Made as independ commit so it can be rollbacked.
2021-07-13 10:34:25 +02:00
tfreville
fbed999ad8 feat(step_definition): Allows to define step function without return.
Issue: It is not possible to use function without return when
       matching steps, resulting in a lot of Nil only error
       returns.

Fix: Allows to provide empty result function by correctly matching
     reflect Calls on step Handler.
     When nothing is returned by the Handler, it will return
     nil as if errors was nil.
2021-07-13 10:31:39 +02:00
Viacheslav Poturaev
c6e9cd0e19 Revert return logic to restore previous behavior and pass the original test 2021-07-07 20:12:56 +02:00
MBow
5414f3c5da update gherkin-go to v19.0.3
update messages-go to v16.0.1
bump gomod version
comment on log line in std os.Stderr
examples to non rc version
go mod tidy
update circle (tbd)
2021-06-28 17:19:43 +01:00
Hiram Chirino
2b6c9dc82e feat: support auto converting doc strings to plain strings 2021-03-16 09:40:37 +01:00
Fredrik Lönnblad
2fa3b9f08c Moved StepDefinition to the formatters pkg 2020-07-11 10:49:36 +02:00
Fredrik Lönnblad
150c400163 Created internal packages for formatters, storage and models 2020-07-02 08:51:31 +02:00