From 1aac8a0cb18b426800898708cdff95d5e816df87 Mon Sep 17 00:00:00 2001 From: sago35 Date: Fri, 19 Feb 2021 08:26:32 +0900 Subject: [PATCH] atsamd5x: avoid infinite loop when USBCDC is disconnected --- src/machine/machine_atsamd51.go | 31 +++++++++++++++++++++++-------- 1 file changed, 23 insertions(+), 8 deletions(-) diff --git a/src/machine/machine_atsamd51.go b/src/machine/machine_atsamd51.go index 1553d167..736826bb 100644 --- a/src/machine/machine_atsamd51.go +++ b/src/machine/machine_atsamd51.go @@ -1734,17 +1734,19 @@ func (pwm PWM) getMux() PinMode { // USBCDC is the USB CDC aka serial over USB interface on the SAMD21. type USBCDC struct { - Buffer *RingBuffer - TxIdx volatile.Register8 - waitTxc bool - sent bool + Buffer *RingBuffer + TxIdx volatile.Register8 + waitTxc bool + waitTxcRetryCount uint8 + sent bool } const ( - usbcdcTxSizeMask uint8 = 0x3F - usbcdcTxBankMask uint8 = ^usbcdcTxSizeMask - usbcdcTxBank1st uint8 = 0x00 - usbcdcTxBank2nd uint8 = usbcdcTxSizeMask + 1 + usbcdcTxSizeMask uint8 = 0x3F + usbcdcTxBankMask uint8 = ^usbcdcTxSizeMask + usbcdcTxBank1st uint8 = 0x00 + usbcdcTxBank2nd uint8 = usbcdcTxSizeMask + 1 + usbcdcTxMaxRetriesAllowed uint8 = 5 ) // Flush flushes buffered data. @@ -1760,6 +1762,7 @@ func (usbcdc *USBCDC) Flush() error { return nil } usbcdc.waitTxc = true + usbcdc.waitTxcRetryCount = 0 // set the data usbEndpointDescriptors[usb_CDC_ENDPOINT_IN].DeviceDescBank[1].ADDR.Set(uint32(uintptr(unsafe.Pointer(&udd_ep_in_cache_buffer[usb_CDC_ENDPOINT_IN][bk])))) @@ -1806,6 +1809,14 @@ func (usbcdc *USBCDC) WriteByte(c byte) error { if ok { break + } else if usbcdcTxMaxRetriesAllowed < UART0.waitTxcRetryCount { + mask := interrupt.Disable() + UART0.waitTxc = false + UART0.waitTxcRetryCount = 0 + usbcdc.TxIdx.Set(0) + usbLineInfo.lineState = 0 + interrupt.Restore(mask) + break } else { mask := interrupt.Disable() if UART0.sent { @@ -2035,6 +2046,10 @@ func handleUSBIRQ(interrupt.Interrupt) { } } } + + if i == usb_CDC_ENDPOINT_IN && UART0.waitTxc { + UART0.waitTxcRetryCount++ + } } UART0.Flush()