From 3b1759f4634b929b1fccb8257b81a94beb9d9722 Mon Sep 17 00:00:00 2001
From: Ayke van Laethem <aykevanlaethem@gmail.com>
Date: Tue, 24 Mar 2020 15:29:31 +0100
Subject: [PATCH] transform: fix error in interface lowering pass

It appears that LLVM can sometimes recognize that multiple calls to
runtime.interfaceMethod can be merged into one. When that happens, the
interface lowering pass shows an error as it didn't expect that
situation.

Luckily the fix is very easy.
---
 transform/interface-lowering.go | 45 +++++++++++++++------------------
 1 file changed, 21 insertions(+), 24 deletions(-)

diff --git a/transform/interface-lowering.go b/transform/interface-lowering.go
index 2f85e79c..53e248d3 100644
--- a/transform/interface-lowering.go
+++ b/transform/interface-lowering.go
@@ -317,33 +317,30 @@ func (p *lowerInterfacesPass) run() error {
 			}
 			inttoptr := inttoptrs[0]
 			calls := getUses(inttoptr)
-			if len(calls) != 1 || calls[0].IsACallInst().IsNil() {
-				return errorAt(use, "internal error: expected exactly one call use of runtime.interfaceMethod")
-			}
-			call := calls[0]
+			for _, call := range calls {
+				// Set up parameters for the call. First copy the regular params...
+				params := make([]llvm.Value, call.OperandsCount())
+				paramTypes := make([]llvm.Type, len(params))
+				for i := 0; i < len(params)-1; i++ {
+					params[i] = call.Operand(i)
+					paramTypes[i] = params[i].Type()
+				}
+				// then add the typecode to the end of the list.
+				params[len(params)-1] = typecode
+				paramTypes[len(params)-1] = p.uintptrType
 
-			// Set up parameters for the call. First copy the regular params...
-			params := make([]llvm.Value, call.OperandsCount())
-			paramTypes := make([]llvm.Type, len(params))
-			for i := 0; i < len(params)-1; i++ {
-				params[i] = call.Operand(i)
-				paramTypes[i] = params[i].Type()
-			}
-			// then add the typecode to the end of the list.
-			params[len(params)-1] = typecode
-			paramTypes[len(params)-1] = p.uintptrType
+				// Create a function that redirects the call to the destination
+				// call, after selecting the right concrete type.
+				redirector := p.getInterfaceMethodFunc(itf, signature, call.Type(), paramTypes)
 
-			// Create a function that redirects the call to the destination
-			// call, after selecting the right concrete type.
-			redirector := p.getInterfaceMethodFunc(itf, signature, call.Type(), paramTypes)
-
-			// Replace the old lookup/inttoptr/call with the new call.
-			p.builder.SetInsertPointBefore(call)
-			retval := p.builder.CreateCall(redirector, append(params, llvm.ConstNull(llvm.PointerType(p.ctx.Int8Type(), 0))), "")
-			if retval.Type().TypeKind() != llvm.VoidTypeKind {
-				call.ReplaceAllUsesWith(retval)
+				// Replace the old lookup/inttoptr/call with the new call.
+				p.builder.SetInsertPointBefore(call)
+				retval := p.builder.CreateCall(redirector, append(params, llvm.ConstNull(llvm.PointerType(p.ctx.Int8Type(), 0))), "")
+				if retval.Type().TypeKind() != llvm.VoidTypeKind {
+					call.ReplaceAllUsesWith(retval)
+				}
+				call.EraseFromParentAsInstruction()
 			}
-			call.EraseFromParentAsInstruction()
 			inttoptr.EraseFromParentAsInstruction()
 			use.EraseFromParentAsInstruction()
 		}