From 6b73b5e4860a060e5196080c6485fa6b6c2b8fe5 Mon Sep 17 00:00:00 2001 From: Damian Gryski Date: Wed, 22 Mar 2023 09:33:57 -0700 Subject: [PATCH] reflect: document which Convert() cases are still unimplemented --- src/reflect/value.go | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/reflect/value.go b/src/reflect/value.go index 2c238efd..2cbd4a7c 100644 --- a/src/reflect/value.go +++ b/src/reflect/value.go @@ -1154,8 +1154,6 @@ func convertOp(src Value, typ Type) (Value, bool) { } } - // TODO(dgryski): Implement other cases - case String: rtype := typ.(*rawType) if typ.Kind() == Slice && !rtype.elem().isNamed() { @@ -1166,9 +1164,14 @@ func convertOp(src Value, typ Type) (Value, bool) { return cvtStringRunes(src, rtype), true } } - } + // TODO(dgryski): Unimplemented: + // Chan + // Identical underlying types + // Non-defined pointers types with same underlying base type + // Interface <-> Type conversions + return Value{}, false }