From a5a90a57b9a575ce7605219d0342a6dc04e800b3 Mon Sep 17 00:00:00 2001 From: Ayke van Laethem Date: Thu, 26 Dec 2019 02:31:47 +0100 Subject: [PATCH] main: remove getting a serial port in gdb subcommand Remove this code for two reasons: 1. It is not needed. 2. It breaks `tinygo gdb` for debugging QEMU targets (such as cortex-m-qemu). --- main.go | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/main.go b/main.go index dea040b5..f9059d2d 100644 --- a/main.go +++ b/main.go @@ -274,15 +274,7 @@ func Flash(pkgName, port string, options *compileopts.Options) error { // // Note: this command is expected to execute just before exiting, as it // modifies global state. -func FlashGDB(pkgName, port string, ocdOutput bool, options *compileopts.Options) error { - if port == "" { - var err error - port, err = getDefaultPort() - if err != nil { - return err - } - } - +func FlashGDB(pkgName string, ocdOutput bool, options *compileopts.Options) error { config, err := builder.NewConfig(options) if err != nil { return err @@ -769,7 +761,7 @@ func main() { usage() os.Exit(1) } - err := FlashGDB(flag.Arg(0), *port, *ocdOutput, options) + err := FlashGDB(flag.Arg(0), *ocdOutput, options) handleCompilerError(err) } case "run":