From a6200920f70f40ffd0cd5b89e9f426c145eaa278 Mon Sep 17 00:00:00 2001 From: Kenneth Bell Date: Wed, 24 Nov 2021 20:55:12 +0000 Subject: [PATCH] stm32: pull-up on I2C lines fixes #2310 --- src/machine/machine_stm32_moder_gpio.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/machine/machine_stm32_moder_gpio.go b/src/machine/machine_stm32_moder_gpio.go index ec4a7c17..68d58c32 100644 --- a/src/machine/machine_stm32_moder_gpio.go +++ b/src/machine/machine_stm32_moder_gpio.go @@ -1,3 +1,4 @@ +//go:build stm32 && !stm32f103 // +build stm32,!stm32f103 package machine @@ -110,13 +111,13 @@ func (p Pin) ConfigureAltFunc(config PinConfig, altFunc uint8) { port.MODER.ReplaceBits(gpioModeAlternate, gpioModeMask, pos) port.OTYPER.ReplaceBits(stm32.GPIO_OTYPER_OT0_OpenDrain, stm32.GPIO_OTYPER_OT0_Msk, pos/2) port.OSPEEDR.ReplaceBits(gpioOutputSpeedLow, gpioOutputSpeedMask, pos) - port.PUPDR.ReplaceBits(gpioPullFloating, gpioPullMask, pos) + port.PUPDR.ReplaceBits(gpioPullUp, gpioPullMask, pos) p.SetAltFunc(altFunc) case PinModeI2CSDA: port.MODER.ReplaceBits(gpioModeAlternate, gpioModeMask, pos) port.OTYPER.ReplaceBits(stm32.GPIO_OTYPER_OT0_OpenDrain, stm32.GPIO_OTYPER_OT0_Msk, pos/2) port.OSPEEDR.ReplaceBits(gpioOutputSpeedLow, gpioOutputSpeedMask, pos) - port.PUPDR.ReplaceBits(gpioPullFloating, gpioPullMask, pos) + port.PUPDR.ReplaceBits(gpioPullUp, gpioPullMask, pos) p.SetAltFunc(altFunc) // SPI