From c1aa152a63683f21b163a8390ddb6db0a01aa59c Mon Sep 17 00:00:00 2001 From: Ayke van Laethem Date: Wed, 5 May 2021 14:49:55 +0200 Subject: [PATCH] unix: avoid possible heap allocation with -opt=0 This heap allocation would normally be optimized away, but with -opt=0 perhaps not. This is a problem if the conservative GC is used, because the conservative GC needs to be initialized before use. --- src/runtime/runtime_unix.go | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/src/runtime/runtime_unix.go b/src/runtime/runtime_unix.go index dc6d7485..59a28682 100644 --- a/src/runtime/runtime_unix.go +++ b/src/runtime/runtime_unix.go @@ -55,18 +55,16 @@ func main(argc int32, argv *unsafe.Pointer) int { cap uintptr })(unsafe.Pointer(&args)) argsSlice.ptr = malloc(uintptr(argc) * (unsafe.Sizeof(uintptr(0))) * 3) - argsSlice.len = 0 + argsSlice.len = uintptr(argc) argsSlice.cap = uintptr(argc) // Initialize command line parameters. - for *argv != nil { + for i := 0; i < int(argc); i++ { // Convert the C string to a Go string. length := strlen(*argv) - argString := _string{ - length: length, - ptr: (*byte)(*argv), - } - args = append(args, *(*string)(unsafe.Pointer(&argString))) + arg := (*_string)(unsafe.Pointer(&args[i])) + arg.length = length + arg.ptr = (*byte)(*argv) // This is the Go equivalent of "argc++" in C. argv = (*unsafe.Pointer)(unsafe.Pointer(uintptr(unsafe.Pointer(argv)) + unsafe.Sizeof(argv))) }