* Minor doc and comment corrections
* Fixed bug where it was impossible to make attachments from 'after scenario' hook, also removed some dud comments.
* typo
* added basic detection for ambiguous steps, but causes an error and not yet recorded in the reports as 'Ambiguous', and no test cases figured out yet
* added initial support for detection of ambiguous steps - further work take a look at how cuke jvm report ambiguous steps and sets the step status to 'ambiguous' rather than my current solution which just blows the test up as a regular step error
* added suite_context_test and also introduced missing 'ambiguous' status to make cucumber jvm'
* update CHANGELOG for ambiguous step defs
* missed file from commit
* added internal/formatters/fmt_multi_test.go
* add tests for other peoples code
* added "ambigous" to the help text
* tests
* added some more tests for attachments
* Update internal/flags/flags.go
Co-authored-by: Viacheslav Poturaev <nanopeni@gmail.com>
---------
Co-authored-by: Viacheslav Poturaev <nanopeni@gmail.com>
* support multiple calls to the Attach() function from a single step
* run_progress_test.go changed so it's not sensitive to the name of the clone target directory
* applied code review comments also added _example/attachments
* applied code review comments also added _example/attachments
* applied code review comments also added _example/attachments
* Attempting to provide a useful implementation of something compatible with testing.T
* Handle Fail calls on the TestingT in the right place
* Provide as much of testing.T as possible + tidy up
* Add initial tests for testingT support
* Check compatibility with testing.T and friends
Co-authored-by: Piotr Bocheński <bochenski.piotr@gmail.com>
* Update assert-godogs example to show new usage. Rename 'GetTestingT(ctx)' to 'T(ctx)'
* Update changelog and readme with new usage
* Improve test coverage
* Review updates
---------
Co-authored-by: Piotr Bocheński <bochenski.piotr@gmail.com>
feat(*): create keyword functions
* chore(*): update messages and gherkin, relocate Keyword
* chore(*): update messages and gherkin, relocate Keyword
* chore(*): update messages and gherkin, relocate Keyword
* feat(*): mandate keyword type when unambiguous keyword function is used
* test(*): keyword type in feature files
* docs(*): update step-by-step walkthrough to mention the option of using keyword functions
* docs(*): update CHANGELOG.md
* test(*): keyword substeps
* chore(*): go mod
* Switch from golint to staticcheck
* Remove unused function
run_test.go:618:6: func passingStepDefWithoutReturn is unused (U1000)
* Remove unused function
suite.go:421:6: func isEmptyFeature is unused (U1000)
* Fix unnecessary use of fmt.Sprintf
test_context_test.go:45:66: unnecessary use of fmt.Sprintf (S1039)
test_context_test.go:46:61: unnecessary use of fmt.Sprintf (S1039)
* Fix CI error
https://github.com/cucumber/godog/runs/5146601108?check_suite_focus=true#step:7:28
* Change CI to run staticcheck instead of golint
* Use staticcheck that definitely pass
* Fix CI staticcheck error
https://github.com/cucumber/godog/runs/5147133955?check_suite_focus=true#step:6:17
* Only run staticcheck for Go 1.17
Co-authored-by: Viacheslav Poturaev <nanopeni@gmail.com>
* Add staticcheck linux binary
* Update Go module dependencies in _examples
* Use static check binary in bin for CI
* Reduce number of dependencies
Also add a note to CONTRIBUTING.md about the _examples module
* Pin the version of staticcheck
Co-authored-by: Viacheslav Poturaev <nanopeni@gmail.com>
Co-authored-by: Matt Wynne <matt@cucumber.io>
Co-authored-by: Viacheslav Poturaev <nanopeni@gmail.com>
* Add new contextualized API for hooks and steps
* Make default context configurable
* Run AfterStep hooks even after failed steps, fixes#370
* Update CHANGELOG and README
* Add step result status to After hook, fixes#378
* Elaborate hooks documentation
* Add test to pass state between contextualized steps
* Update README with example of passing state between steps
